Correctly dealing with location is essential to correctly generate OCaml code. They are necessary for error reporting by the compiler, but more generally for Merlin's features to work, such as displaying occurrences and jumping to definition. When called, the driver is called with the -check and -check-locations flags, ppxlib makes it is a requirement that locations follow some rules in order to accept the rewriting, as it will check that some invariants are respected.
The invariants are as follows:
This is required for Merlin to behave properly.
Indeed, for almost any query directed at Merlin, it will need to inspect the context around the user's cursor to give an answer that makes sense. And the only input it has to do that is the cursor’s position in the buffer. The handling of most queries starts by traversing the AST, using the locations of nodes to select the right branch. (1) is necessary to avoid discarding subtrees too early, (2) is used to avoid Merlin making arbitrary choices (if you ask for the type under the cursor, and there seems to be two things under the cursor, Merlin will need to pick one).
It's obviously not always (indeed rarely) possible to mint new locations when manipulating the AST.
The intended way to deal with locations is this:
{ some_loc with loc_ghost = true }) to indicate that the node doesn't exist in the sources.In particular, Location.none is never meant to be used by PPX authors, where some location is always available (for instance, derivers and extenders at least know the locations of their relevant node).
Both the new check and Merlin will happily traverse the ghost nodes as if they didn't exist. Note: this comes into play when deciding which nodes are "siblings," for instance, if your AST is:
A (B1(C, D),
B2(X, Y))but B2 has a ghost location, then B1, X and Y are considered siblings.
Additionally, there is an attribute [@merlin.hide] that you can add on nodes to tell Merlin (and the check) to ignore this node and all of its children. Some helpers for this are provided in Merlin_helpers.
In order to give a nice user experience when using a PPX, it is necessary that the resulting parsetree is as complete as possible. Most IDE tools, such as Merlin, rely on the AST for their features, such as displaying type, jumping to definition, or showing the list of errors.
In order to achieve this, errors that happen during rewriting should be handled in a way that do not prevent a meaningful AST to be passed to Merlin.
There are mainly two ways to report errors when writing a PPX.
Let us emphasize that, while exceptions can be practical to quickly fail with an error, the embedding mechanism has many advantages. For instance, embedding allows to report multiple errors, and to output the part of the code that could be generated successfully.
It is better to always return a valid AST, as complete as possible, but with "error extension nodes" at every place where successful code generation was impossible. Error extension nodes are special extension nodes [%ocaml.error "error_message"] that can be embedded into a valid AST and are interpreted later as errors, e.g., by the compiler or Merlin. As all extension nodes, they can be put at many places in the AST to replace structure items, expressions, or patterns, for example.
So whenever you're in doubt whether to throw an exception or if to embed the error as an error extension node when writing a PPX rewriter, embed the error is the way to go! And whenever you're in doubt about where exactly to embed the error inside the AST, a good ground rule is: as deep in the AST as possible.
For instance, suppose a rewriter is supposed to define a new record type, but there is an error in one field’s type generation. In order to have the most complete AST as output, the rewriter can still define the type and all of its fields, putting an extension node in place of the type of the faulty field:
type long_record = {
field_1: int;
field_2: [%ocaml.error "field_2 could not be implemented due to foo"];
}ppxlib provides a function in its API to create error extension nodes: error_extensionf. This function creates an extension node, which then must be transformed in the right kind of node using functions such as pexp_extension.
Let us give an example. We will define a deriver on types records, which constructs a default value from a given type. For instance, the derivation on the type type t = { x:int; y: float; z: string} would yield let default_t =
{x= 0; y= 0.; z= ""}. This deriver has two limitations:
string, int, or float.The rewriter should warn the user about these limitations with a good error reporting. Let’s first look at the second point. Here is the function mapping the fields from the type definition to a default expression.
let create_record ~loc fields =
let declaration_to_instantiation (ld : label_declaration) =
let loc = ld.pld_loc in
let { pld_type; pld_name; _ } = ld in
let e =
match pld_type with
| { ptyp_desc = Ptyp_constr ({ txt = Lident "string"; _ }, []); _ } ->
pexp_constant ~loc (Pconst_string ("", loc, None))
| { ptyp_desc = Ptyp_constr ({ txt = Lident "int"; _ }, []); _ } ->
pexp_constant ~loc (Pconst_integer ("0", None))
| { ptyp_desc = Ptyp_constr ({ txt = Lident "float"; _ }, []); _ } ->
pexp_constant ~loc (Pconst_float ("0.", None))
| _ ->
pexp_extension ~loc
@@ Location.error_extensionf ~loc
"Default value can only be derived for int, float, and string."
in
({ txt = Lident pld_name.txt; loc }, e)
in
let l = List.map fields ~f:declaration_to_instantiation in
pexp_record ~loc l NoneWhen the record definition contains several fields with types other than int, float, or string, several error nodes are added in the AST. Moreover, the location of the error nodes corresponds to the field record's definition. This allows tools such as Merlin to report all errors at once, at the right location, resulting in a better workflow than having to recompile every time an error is corrected to see the next one.
The first limitation is that the deriver cannot work on non-record types. However, we decided here to derive a default value, even in the case of non-record types, so that it does not appear as undefined in the remaining of the file. This impossible value consists of an error extension node.
let generate_impl ~ctxt (_rec_flag, type_declarations) =
let loc = Expansion_context.Deriver.derived_item_loc ctxt in
List.map type_declarations ~f:(fun (td : type_declaration) ->
let e, name =
match td with
| { ptype_kind = Ptype_record fields; ptype_name; ptype_loc; _ } ->
(create_record ~loc:ptype_loc fields, ptype_name)
| { ptype_name; ptype_loc; _ } ->
( pexp_extension ~loc
@@ Location.error_extensionf ~loc:ptype_loc
"Cannot derive accessors for non record type %s"
ptype_name.txt,
ptype_name )
in
[
pstr_value ~loc Nonrecursive
[
{
pvb_pat = ppat_var ~loc { txt = "default_" ^ name.txt; loc };
pvb_expr = e;
pvb_attributes = [];
pvb_loc = loc;
};
];
])
|> List.concatQuoting is part of producing hygienic code. But before talking about the solution, let's introduce the problem.
Say you are writing an extension rewriter, which takes an expression as payload, and would replace all identifiers id in the expression with a similar expression, but with a printing debug:
let x = 0 in
let y = 2 in
[%debug x + 1, y + 2 ]would generate the following code:
let x = 0 in
let y = 2 in
let debug = Printf.printf "%s = %d; " in
(debug "x" x ; x) + 1,
(debug "y" y ; y) + 2When executed, the code would print x = 0; y = 2; . So far, so good. However, suppose now that instead of x, the variable is named debug. The following seemingly equivalent code:
let debug = 0 in
let y = 2 in
[%debug debug + 1, y + 2 ]would generate:
let debug = 0 in
let y = 2 in
let debug = Printf.printf "%s = %d; " in
(debug "debug" debug ; debug) + 1,
(debug "y" y ; y) + 2which does not even type-check! The problem is that the payload is expected to be evaluated in some environment where debug has some value and type, but the rewriting modifies this environment and shadows the debug name.
"Quoting" is a mechanism to prevent this problem from happenning. In ppxlib, it is done through the Expansion_helpers.Quoter module in several steps:
create function:# open Expansion_helper ;;
#s let quoter = Quoter.create () ;;
val quoter : Quoter.t = <abstr>Expansion_helpers.Quoter.quote to quote all the expressions that are given from the user, might rely on a context, and that you want "intact."# let quoted_part = Quoter.quote quoter part_to_quote ;;
val quoted_payload : expression =Expansion_helpers.Quoter.sanitize on the whole expression (with quoted parts).# let result = Expansion_helpers.Quoter.sanitize ~quoter rewritten_expression ;;
val result : expression =
...If the debug rewriter had been written using this method, the quoting would have ensured that the payload is evaluated in the same context as the extension node!
Here is an example on how to write a debug rewriter (with the limitation that the payload should not contain variable binding, but the code was left simple to illustrate quoting):
# let rewrite expr =
(* Create a quoter *)
let quoter = Quoter.create () in
(* An AST mapper to log and replace variables with quoted ones *)
let replace_var =
object
(* See the chapter on AST traverse *)
inherit Ast_traverse.map as super
(* in case of expression *)
method! expression expr =
match expr.pexp_desc with
(* in case of identifier (not "+") *)
| Pexp_ident { txt = Lident var_name; loc }
when not (String.equal "+" var_name) ->
(* quote the var *)
let quoted_var = Quoter.quote quoter expr in
let name = Ast_builder.Default.estring ~loc var_name in
(* and rewrite the expression *)
[%expr
debug [%e name] [%e quoted_var];
[%e quoted_var]]
(* otherwise, continue inside recursively *)
| _ -> super#expression expr
end
in
let quoted_rewrite = replace_var#expression expr in
let loc = expr.pexp_loc in
(* Sanitize the whole thing *)
Quoter.sanitize quoter
[%expr
let debug = Printf.printf "%s = %d; " in
[%e quoted_rewrite]] ;;
val rewrite : expression -> expression = <fun>With Ppxlib's current quoting mechanism, the code given in that example would look like:
# Format.printf "%a\n" Pprintast.expression @@ rewrite [%expr debug + 1, y + 2] ;;
let rec __1 = y
and __0 = debug in
let debug = Printf.printf "%s = %d; " in
(((debug "debug" __0; __0) + 1), ((debug "y" __1; __1) + 2))
- : unit = ()This section is not yet written. You can refer to this blog post (notice that that blog post was written before `dune` introduced its cram test feature), or contribute to the ppxlib documentation by opening a pull request in the repository.
This section is not yet written. You can contribute to the ppxlib documentation by opening a pull request in the repository.
There are many good practices or other way to use ppxlib that are not mentioned in this manual. For instance, (in very short), you should always try to fully qualify variable names that are generated into the code via a PPX.
if you want to add a section to this "good practices" manual, you can contribute to the ppxlib documentation by opening a pull request in the repository.